aritragster commented on code in PR #4052:
URL: https://github.com/apache/polaris/pull/4052#discussion_r3047359000
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -200,6 +202,18 @@ private StorageConfigInfo getStorageInfo(Map<String,
String> internalProperties)
.setStorageName(fileConfigModel.getStorageName())
.build();
}
+ if (configInfo instanceof AwsS3TablesStorageConfigurationInfo
s3TablesConfig) {
+ return AwsS3TablesStorageConfigInfo.builder()
+ .setRoleArn(s3TablesConfig.getRoleARN())
+ .setExternalId(s3TablesConfig.getExternalId())
+ .setRegion(s3TablesConfig.getRegion())
+ .setCurrentKmsKey(s3TablesConfig.getCurrentKmsKey())
+ .setAllowedKmsKeys(s3TablesConfig.getAllowedKmsKeys())
+ .setStorageType(StorageConfigInfo.StorageTypeEnum.S3_TABLES)
+ .setAllowedLocations(s3TablesConfig.getAllowedLocations())
+ .setStorageName(s3TablesConfig.getStorageName())
+ .build();
+ }
Review Comment:
Done — moved the S3_TABLES block right after S3 to keep AWS storage types
grouped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
