dimas-b commented on code in PR #4050:
URL: https://github.com/apache/polaris/pull/4050#discussion_r3041749275
##########
spec/polaris-management-service.yml:
##########
@@ -965,6 +967,27 @@ components:
warehouse:
type: string
description: The warehouse location for the hive catalog.
+
+ BigQueryMetastoreConnectionConfigInfo:
+ type: object
+ description: Configuration necessary for connecting to a BigQuery
Metastore Catalog
+ allOf:
+ - $ref: '#/components/schemas/ConnectionConfigInfo'
+ properties:
+ warehouse:
+ type: string
+ description: The warehouse location for the BigQuery Metastore
Catalog
+ gcpProjectId:
+ type: string
+ description: The GCP project ID
+ properties:
+ type: object
+ additionalProperties:
+ type: string
+ description: Additional catalog properties
Review Comment:
Yes, the more I think about it the more I like the idea of supporting
general `properties` inside `ConnectionConfigInfo`. That REST API change should
be able to support both BigQuery Catalog federation and #3729 (CC:
@PhillHenry).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
