dimas-b commented on code in PR #4097:
URL: https://github.com/apache/polaris/pull/4097#discussion_r3034115453
##########
.github/workflows/ci.yml:
##########
@@ -357,8 +383,8 @@ jobs:
-Dquarkus.container-image.build=true
- name: Regression Test
env:
- AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}}
- AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}}
+ AWS_ACCESS_KEY_ID: ${{secrets.AWS_ACCESS_KEY_ID}} # zizmor:
ignore[secrets-outside-env]
+ AWS_SECRET_ACCESS_KEY: ${{secrets.AWS_SECRET_ACCESS_KEY}} # zizmor:
ignore[secrets-outside-env]
Review Comment:
optional: AFAIK, these two secrets are not actually used (and not defined).
I suppose we could remove them for the sake of clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
