adnanhemani opened a new pull request, #4114:
URL: https://github.com/apache/polaris/pull/4114

   Makes some changes to the `verify-release.sh` script to be ready for the 
1.4.0 release.
   * Removes checks related to "reproducible builds". These checks have never 
worked and are producing unactionable noise.
       * Retains these checks in the code for when reproducible builds can be 
done in the future.
   * Polaris Spark Plugin JARs are excluded from the LICENCE/NOTICE checks 
under the META-INF/ directory. The top-level LICENSE/NOTICE is fine, as per 
<INCLUDE ML LINK HERE>
   * Fixes a bug introduced by #3830, [checking the wrong amount of 
files](https://github.com/apache/polaris/pull/3830/changes#diff-a5338da24c3c32e476965b80cd8d84321165ad2b091f408770c305ec66aec549L525-R528).
   
   ## Checklist
   - [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact [email protected])
   - [ ] ๐Ÿ”— Clearly explained why the changes are needed, or linked related 
issues: Fixes #
   - [ ] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and 
explained how)
   - [ ] ๐Ÿ’ก Added comments for complex logic
   - [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to