flyrain commented on code in PR #4091:
URL: https://github.com/apache/polaris/pull/4091#discussion_r3024735393
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -381,15 +387,15 @@ public ListTablesResponse listTables(Namespace namespace,
String pageToken, Inte
PolarisAuthorizableOperation op = PolarisAuthorizableOperation.LIST_TABLES;
authorizeBasicNamespaceOperationOrThrow(op, namespace);
- if (baseCatalog instanceof IcebergCatalog polarisCatalog) {
+ if (isFederated) {
Review Comment:
I thought about that while making this refactor, but due to a lot of common
code, I decide not to do so. But I'm open to it. With the current refactor in
the this PR, it becomes easier if anyone want to do so. Is this a blocker for
this refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
