gh-yzou commented on code in PR #4103:
URL: https://github.com/apache/polaris/pull/4103#discussion_r3023653218
##########
runtime/service/src/main/java/org/apache/polaris/service/credentials/connection/BearerConnectionCredentialVendor.java:
##########
@@ -77,9 +78,11 @@ public BearerConnectionCredentialVendor(UserSecretsManager
secretsManager) {
// Bearer tokens don't expire from Polaris's perspective - set expiration
to Long.MAX_VALUE
// to indicate infinite validity. The token itself may have an expiration,
but that's managed
// by the token issuer, not Polaris.
- return ConnectionCredentials.builder()
- .put(CatalogAccessProperty.BEARER_TOKEN, bearerToken)
- .put(CatalogAccessProperty.EXPIRES_AT_MS,
String.valueOf(Long.MAX_VALUE))
- .build();
+ return ConnectionCredentials.of(
Review Comment:
for some reason i kind of the like the original builder usage, makes caller
little bit cleaner, but I am fine with that way also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
