singhpk234 commented on code in PR #4091:
URL: https://github.com/apache/polaris/pull/4091#discussion_r3014046784
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -218,6 +217,11 @@ public abstract class IcebergCatalogHandler extends
CatalogHandler implements Au
@SuppressWarnings("immutables:incompat")
private ViewCatalog viewCatalog = null;
+ // Indicates whether the catalog is a non-federated (Polaris-managed)
catalog.
+ // Non-federated catalogs support additional capabilities such as pagination,
+ // location transformation, credential vending, and multi-table transactions.
+ private boolean isNonFederated = false;
Review Comment:
Option 1 : how about `isManaged` ? which means catalogs managed by Polaris,
this can replace nonFederated
Option 2: also i wonder what if we filp the neg and positive cases
if (isFederated) {
// existing
} else {
// existing
}
wdyt ? isNon went hand in was a bit hard to reason, though i don't strongly
feel about it, let me know what do you think or option #1 or option #2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
