jbonofre commented on code in PR #4094:
URL: https://github.com/apache/polaris/pull/4094#discussion_r3013936333
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -392,8 +399,16 @@ jobs:
# Retry logic for SVN checkout (Apache SVN can have transient
connectivity issues)
exec_process_with_retries 5 60 "${dist_dev_dir}" svn checkout
--username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive
"${APACHE_DIST_URL}${APACHE_DIST_PATH}" "${dist_dev_dir}"
- exec_process mkdir -p
"${dist_dev_dir}/helm-chart/${version_without_rc}"
- exec_process cp helm/polaris-${version_without_rc}.tgz*
"${dist_dev_dir}/helm-chart/${version_without_rc}/"
+ helm_version_dir="${dist_dev_dir}/helm-chart/${version_without_rc}"
+
+ # If the helm version directory already exists in SVN (e.g.
re-running the workflow),
+ # delete it so we can re-add fresh artifacts without "already
versioned" errors.
+ if svn info "${helm_version_dir}" &>/dev/null 2>&1; then
+ exec_process svn delete "${helm_version_dir}"
Review Comment:
Same here.
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -185,6 +185,13 @@ jobs:
exec_process_with_retries 5 60 "${dist_dev_dir}" svn checkout
--username "$SVN_USERNAME" --password "$SVN_PASSWORD" --non-interactive
"${APACHE_DIST_URL}${APACHE_DIST_PATH}" "${dist_dev_dir}"
version_dir="${dist_dev_dir}/${version_without_rc}"
+
+ # If the version directory already exists in SVN (e.g. re-running
the workflow),
+ # delete it so we can re-add fresh artifacts without "already
versioned" errors.
+ if svn info "${version_dir}" &>/dev/null 2>&1; then
Review Comment:
That's ok, but that's typically a manual action (cleanup between rc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
