huaxingao commented on code in PR #3803:
URL: https://github.com/apache/polaris/pull/3803#discussion_r3013687426
##########
extensions/idempotency/build.gradle.kts:
##########
Review Comment:
Sounds good. Moved to `extensions/idempotency`
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -214,13 +216,32 @@ public FileIOFactory fileIOFactory(
}
@Produces
- @Singleton // used in instanceof checks
+ public PolarisEventListener polarisEventListener(
+ PolarisEventListenerConfiguration config,
+ @Any Instance<PolarisEventListener> polarisEventListeners) {
+ return
polarisEventListeners.select(Identifier.Literal.of(config.type())).get();
+ }
+
+ @Produces
public MetaStoreManagerFactory metaStoreManagerFactory(
PersistenceConfiguration config,
@Any Instance<MetaStoreManagerFactory> metaStoreManagerFactories) {
return
metaStoreManagerFactories.select(Identifier.Literal.of(config.type())).get();
}
+ @Produces
+ @Singleton
+ public IdempotencyStore idempotencyStore(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
