dimas-b commented on code in PR #196: URL: https://github.com/apache/polaris-tools/pull/196#discussion_r2975531400
########## iceberg-catalog-migrator/cli/BUNDLE-NOTICE: ########## @@ -165,3 +165,60 @@ This artifact bundles Netty with the following in its NOTICE: | * HOMEPAGE: | * https://github.com/JCTools/JCTools +------------------------------------------------------------------------- + +This artifact bundles Snappy Java with the following in its NOTICE: +| This product includes software developed by Google Snappy. +| (http://code.google.com/p/snappy) +| +| This product includes software developed by Apache +| PureJavaCrc32C from apache-hadoop-common. +| (http://hadoop.apache.org) + Review Comment: Cf. https://github.com/xerial/snappy-java/blob/main/NOTICE (which version do we bundle?) Why do we not mention the "google" and "PureJavaCrc32C" fragments exactly as in the upstream NOTICE? Why do not mention "libstdc++"? Why do not mention Hadoop? The LICENSE file mentions that it is bundled 🤔 Should we also include the "Contributors" section from upstream? I tend to think we should since it's part of Snappy-java's original NOTICE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
