castanhas98 commented on code in PR #4034:
URL: https://github.com/apache/polaris/pull/4034#discussion_r2968484814
##########
runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogMinIOSpecialIT.java:
##########
@@ -265,8 +301,89 @@ public void testCreateTableVendedCredentials(boolean
pathStyle) throws IOExcepti
assertThat(response.credentials()).hasSize(1);
}
+ @ParameterizedTest
+ @CsvSource({
+ "false, false, false",
+ "true, false, false",
+ "false, true, false",
+ "true, true, true",
+ })
+ public void
testCreateTableVendedCredentialsWithAwsShapeTriggersMinioKmsFailure(
+ boolean includeRegion, boolean includeRoleArn, boolean expectFailure)
throws IOException {
+ try (RESTCatalog restCatalog =
+ createCatalog(
+ Optional.of(endpoint),
+ Optional.of(endpoint),
+ true,
+ Optional.empty(),
+ Optional.of(VENDED_CREDENTIALS),
+ true,
+ includeRegion ? Optional.of(TEST_REGION) : Optional.empty(),
+ includeRoleArn ? Optional.of(TEST_ROLE_ARN) : Optional.empty(),
+ Optional.of(false))) {
+ TableIdentifier id = createTableAndVerifyMetadata(restCatalog);
+ if (expectFailure) {
Review Comment:
Refactored this into separate success and failure tests so the expected
behavior is easier to scan and diagnose. I also reran the targeted MinIO/KMS
integration tests locally after the split. Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
