dimas-b commented on code in PR #3947: URL: https://github.com/apache/polaris/pull/3947#discussion_r2940148318
########## persistence/nosql/admin/cmd/src/main/java/org/apache/polaris/admintool/nosql/Placeholder.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.admintool.nosql; + +import jakarta.enterprise.context.ApplicationScoped; + +/** + * Something with a "bean-producing" annotation is required by Quarkus to "notice" this module, yet + * Quarkus will find CLI commands only if they are `@Default`, so `@ApplicationScoped` cannot be + * applied to them... hence the workaround with this placeholder just to hold the + * `@ApplicationScoped` annotation. + */ Review Comment: Yes. Quarkus does not "see" custom qualifiers (like `@AdminSubCommand`). Since `persistence/nosql/admin/cmd` does not have any standard "bean-defining" annotations, Quarkus will not consider it when looking for `@AdminSubCommand` implementations. I guess this is an interplay of some no-so-standard Quarkus approach to implementing CLI (note that Quarkus considered only `@Default` beans for CLI commands) and me wanting to leverage `@AdminSubCommand` to allow pluggable CLI modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
