adutra commented on PR #3750: URL: https://github.com/apache/polaris/pull/3750#issuecomment-4048804913
> Re: checked-and-egg problem: I believe only `checkAllowExternalCatalogCredentialVending()` needs to consider delegation mode parameters. Well, there is also `buildLoadTableResponseWithDelegationCredentials()` that (obviously) needs the resolved mode. > Basically, if the client requests both REMOTE_SIGNING and VENDED_CREDENTIALS for a Federated catalog, we can simply drop VENDED_CREDENTIALS and continue execution. If only VENDED_CREDENTIALS is requested, it's an error (same as now). Hmm I think I see what you mean, you would like to move the check for `FeatureConfiguration.ALLOW_EXTERNAL_CATALOG_CREDENTIAL_VENDING` into the resolver, where we already have the check for `FeatureConfiguration.ALLOW_FEDERATED_CATALOGS_CREDENTIAL_VENDING`. I like the idea 👍 This places these two checks side by side in the same place, which I think will help us eventually decide on merging them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
