adutra commented on code in PR #3940:
URL: https://github.com/apache/polaris/pull/3940#discussion_r2918639340
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/ResolverPath.java:
##########
@@ -24,14 +24,14 @@
/**
* Simple class to represent a path within a catalog
*
- * @param entityNames name of the entities in that path. The parent of the
first named entity is the
- * path is the catalog
- * @param lastEntityType all entities in a path are namespaces except the last
one which can be a
- * table_like entity versus a namespace
+ * @param key canonical path key (entity names + terminal entity type)
* @param optional true if this path is optional, i.e. failing to fully
resolve it is not an error
*/
-public record ResolverPath(
- List<String> entityNames, PolarisEntityType lastEntityType, boolean
optional) {
+public record ResolverPath(ResolvedPathKey key, boolean optional) {
+
+ public ResolverPath {
+ key = new ResolvedPathKey(key.entityNames(), key.entityType());
Review Comment:
nit: do we need this defensive copy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
