adutra commented on code in PR #3969:
URL: https://github.com/apache/polaris/pull/3969#discussion_r2913004344
##########
helm/polaris/templates/httproute.yaml:
##########
@@ -41,8 +41,21 @@ spec:
sectionName: {{ .Values.httproute.sectionName }}
{{- end }}
rules:
- # We don't specify a matches block here, so the default is a prefix path
match on "/" (match every HTTP request)
- # The backend (Service) to send matching requests to
+ {{- if .Values.httproute.exposeManagementEndpoints }}
+ - matches:
+ - path:
+ type: PathPrefix
+ value: "/mgmt"
+ backendRefs:
+ - name: {{ include "polaris.fullnameWithSuffix" (list . "mgmt") }}
+ port: {{ get (first .Values.managementService.ports) "port" }}
+ filters:
+ - type: URLRewrite
+ urlRewrite:
+ path:
+ type: ReplacePrefixMatch
+ replacePrefixMatch: "/"
Review Comment:
If we want just healthchecks, maybe something like this is better:
```yaml
- matches:
- path:
type: PathPrefix
value: "/q/health"
backendRefs:
- name: {{ include "polaris.fullnameWithSuffix" (list . "mgmt") }}
port: {{ get (first .Values.managementService.ports) "port" }}
filters:
- type: URLRewrite
urlRewrite:
path:
type: ReplacePrefixMatch
replacePrefixMatch: "/q/health"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
