dimas-b commented on code in PR #3915:
URL: https://github.com/apache/polaris/pull/3915#discussion_r2912044477
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/idempotency/RelationalJdbcIdempotencyStore.java:
##########
@@ -190,27 +195,67 @@ public HeartbeatResult updateHeartbeat(
return HeartbeatResult.LOST_OWNERSHIP;
}
+ @Override
+ public void cancelInProgressReservation(
+ String realmId, String idempotencyKey, String executorId) {
+ try {
+ QueryGenerator.PreparedQuery delete =
+ QueryGenerator.generateDeleteQuery(
+ ModelIdempotencyRecord.ALL_COLUMNS,
+ ModelIdempotencyRecord.TABLE_NAME,
+ Map.of(
+ ModelIdempotencyRecord.REALM_ID,
+ realmId,
+ ModelIdempotencyRecord.IDEMPOTENCY_KEY,
+ idempotencyKey,
+ ModelIdempotencyRecord.EXECUTOR_ID,
+ executorId),
+ Map.of(),
+ Map.of(),
+ Set.of(ModelIdempotencyRecord.HTTP_STATUS),
+ Set.of());
+ datasourceOperations.executeUpdate(delete);
+ } catch (SQLException e) {
+ throw new IdempotencyPersistenceException(
Review Comment:
Why does the IT test pass with a type mismatch? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
