adriangb commented on code in PR #628:
URL: https://github.com/apache/parquet-format/pull/628#discussion_r4214251720
##########
src/main/thrift/parquet.thrift:
##########
@@ -289,7 +289,10 @@ struct Statistics {
* If null_count is not present, readers MUST NOT assume null_count == 0.
*/
3: optional i64 null_count;
- /** count of distinct values occurring */
+ /**
+ * Estimated count of distinct values occurring.
+ * The estimate may be off in either direction by an underfined amount.
Review Comment:
Thanks for the suggestion Daniel. What does this buy in practice? Is this
definition well defined enough that it unlocks some use cases that are
otherwise blocked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]