wgtmac commented on code in PR #606:
URL: https://github.com/apache/parquet-format/pull/606#discussion_r3915941802


##########
LogicalTypes.md:
##########
@@ -54,6 +56,13 @@ in case `LogicalType` annotations are not present. Parquet 
writers must always w
 `LogicalType` annotations where applicable, but must also write the 
corresponding
 `ConvertedType` annotations (if any) to maintain compatibility with old 
readers.
 
+#### Unsupported Logical Types
+
+When reading a file written by a newer writer that contains an unrecognized 
logical type or an
+unrecognized logical/physical type combination on a column, readers should 
ignore both the logical
+type annotation and statistics for that column. Only the physical type 
information should be used

Review Comment:
   Not sure if this has been discussed before. But not all kinds of 
`statistics` should be ignored, e.g. null_count. Should we instead say `readers 
should ignore both the logical type annotation and column order for that 
column`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to