divjotarora commented on code in PR #3709: URL: https://github.com/apache/parquet-java/pull/3709#discussion_r3907596431
########## dev/update-parquet-thrift.sh: ########## @@ -0,0 +1,127 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Updates the inlined parquet.thrift and sidecar to a specific parquet-format +# commit or tag. +# +# Usage: +# update-parquet-thrift.sh <ref> +# +# <ref> is a full 40-char parquet-format commit SHA, or a parquet-format tag +# (e.g. apache-parquet-format-2.13.0). + +set -euo pipefail + +SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)" +THRIFT_FILE="${REPO_ROOT}/parquet-format-structures/src/main/thrift/parquet.thrift" +SIDECAR_FILE="${REPO_ROOT}/parquet-format-structures/src/main/thrift/parquet-format.version" + +PARQUET_FORMAT_REPO="https://github.com/apache/parquet-format"; Review Comment: Done, the script honors `PARQUET_FORMAT_REPO` if set and defaults to apache/parquet-format if not. Tested via ``` > PARQUET_FORMAT_REPO="https://github.com/divjotarora/parquet-format"; ./dev/update-parquet-thrift.sh f4288e602a41deba78c58e8bd116b36076a03588 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
