rdblue commented on code in PR #3709: URL: https://github.com/apache/parquet-java/pull/3709#discussion_r3884248136
########## dev/prepare-release.sh: ########## @@ -38,6 +38,9 @@ new_development_version="$release_version-SNAPSHOT" tag="apache-parquet-$release_version-rc$2" +# Ensure the inlined parquet.thrift matches an official parquet-format release. +"$(dirname "$0")/check-parquet-thrift-release.sh" Review Comment: I think this is an unnecessary requirement. This assumes that we can only release Parquet Java if there has also been a release of Parquet Format, which is beyond the scope of what we are trying to do here. The primary purpose of this change is to use a local copy of parquet.thrift. A secondary concern is helping us to update that file easily and know when it has changed. I think we should remove changes to the release script unless we decide to make this a requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
