danielcweeks commented on code in PR #603: URL: https://github.com/apache/parquet-format/pull/603#discussion_r3729741102
########## LogicalTypes.md: ########## @@ -688,11 +688,11 @@ external reference (`uri` set). `offset` must not be < 0. ##### size -The byte length of the referenced data. Must be zero or a positive integer if set; a -value of 0 indicates empty referenced data. `size` must be set whenever `offset` is set. -It may be omitted only for a whole-file external reference (`uri` set, `offset` not set), -in which case the range runs to the end of the referenced file. Because a self-reference -always sets `offset`, it always sets `size` as well. +The byte length of the stored representation. Must be zero or a positive integer if set. +A value of 0 indicates an empty stored representation. `size` must be set whenever +`offset` is set. It may be omitted only for a whole-file external reference (`uri` set, +`offset` not set), in which case the range runs to the end of the referenced file. +Because a self-reference always sets `offset`, it always sets `size` as well. Review Comment: ```suggestion Because a self-reference always sets `offset`, it must always set `size` as well. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
