steveloughran commented on PR #3589:
URL: https://github.com/apache/parquet-java/pull/3589#issuecomment-4554294574

   new thrift is triggering NPEs in tests. That is *bad*
   ```
   Error:  
org.apache.parquet.hadoop.thrift.TestParquetToThriftReadWriteAndProjection.testPullInRequiredLists
 -- Time elapsed: 0.027 s <<< ERROR!
   org.apache.parquet.io.ParquetDecodingException: Can not read value at 1 in 
block 0 in file 
file:/home/runner/work/parquet-java/parquet-java/parquet-thrift/target/test/TestParquetToThriftReadWriteAndProjection/file.parquet
        at 
org.apache.parquet.hadoop.InternalParquetRecordReader.nextKeyValue(InternalParquetRecordReader.java:280)
        at 
org.apache.parquet.hadoop.ParquetRecordReader.nextKeyValue(ParquetRecordReader.java:207)
        at 
org.apache.parquet.hadoop.thrift.TestParquetToThriftReadWriteAndProjection.shouldDoProjection(TestParquetToThriftReadWriteAndProjection.java:375)
        at 
org.apache.parquet.hadoop.thrift.TestParquetToThriftReadWriteAndProjection.shouldDoProjectionWithThriftColumnFilter(TestParquetToThriftReadWriteAndProjection.java:337)
        at 
org.apache.parquet.hadoop.thrift.TestParquetToThriftReadWriteAndProjection.testPullInRequiredLists(TestParquetToThriftReadWriteAndProjection.java:301)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   Caused by: java.lang.NullPointerException
        at 
org.apache.thrift.protocol.TProtocol.incrementRecursionDepth(TProtocol.java:59)
        at 
org.apache.parquet.thrift.test.RequiredListFixture$RequiredListFixtureStandardScheme.read(RequiredListFixture.java:414)
        at 
org.apache.parquet.thrift.test.RequiredListFixture$RequiredListFixtureStandardScheme.read(RequiredListFixture.java:410)
        at 
org.apache.parquet.thrift.test.RequiredListFixture.read(RequiredListFixture.java:345)
        at 
org.apache.parquet.thrift.TBaseRecordConverter$1.readOneRecord(TBaseRecordConverter.java:63)
        at 
org.apache.parquet.thrift.TBaseRecordConverter$1.readOneRecord(TBaseRecordConverter.java:58)
        at 
org.apache.parquet.thrift.ThriftRecordConverter.getCurrentRecord(ThriftRecordConverter.java:945)
        at 
org.apache.parquet.io.RecordReaderImplementation.read(RecordReaderImplementation.java:439)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to