divjotarora opened a new pull request, #3588:
URL: https://github.com/apache/parquet-java/pull/3588

   ### Rationale for this change
   This PR fixes a small bug in `parquet.thrift.string.size.limit` validation 
[here](https://github.com/apache/parquet-java/blob/8931c1c55f1fba399dd75139f75bcde0b84137c0/parquet-format-structures/src/main/java/org/apache/parquet/format/Util.java#L420).
 If this config is explicitly set to -1, the code indicates that the default 
max message size should be used, but also throws an exception.
   
   
   ### What changes are included in this PR?
   If `parquet.thrift.string.size.limit == -1`, use the default value and do 
not fail validation.
   
   
   ### Are these changes tested?
   Yes, there are new regression tests added to 
`TestParquetFileReaderMaxMessageSize`.
   
   
   ### Are there any user-facing changes?
   No.
   
   
   <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the 
actual Github issue id. -->
   Closes #GH-3587
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to