dossett commented on code in PR #3318:
URL: https://github.com/apache/parquet-java/pull/3318#discussion_r2363403848
##########
parquet-thrift/src/test/java/org/apache/parquet/hadoop/thrift/TestParquetToThriftReadWriteAndProjection.java:
##########
@@ -333,7 +196,7 @@ public void testPullInPrimitiveValues() throws Exception {
private void shouldDoProjectionWithThriftColumnFilter(
String filterDesc, TBase toWrite, TBase toRead, Class<? extends TBase<?,
?>> thriftClass) throws Exception {
Configuration conf = new Configuration();
- conf.set(ThriftReadSupport.THRIFT_COLUMN_FILTER_KEY, filterDesc);
+ conf.set(ThriftReadSupport.STRICT_THRIFT_COLUMN_FILTER_KEY, filterDesc);
Review Comment:
This file was exclusively testing the deprecated thrift filter. I switched
it to test the supported "strict" filter but could not recreate the
functionality of several of the tests. This isn't really a regression in test
coverage since the strict filter was not being tested at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
