gszadovszky commented on code in PR #3243:
URL: https://github.com/apache/parquet-java/pull/3243#discussion_r2348122876
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -762,12 +772,12 @@ public List<PageEncodingStats>
convertEncodingStats(EncodingStats stats) {
return formatStats;
}
- public static Statistics
toParquetStatistics(org.apache.parquet.column.statistics.Statistics stats) {
- return toParquetStatistics(stats,
ParquetProperties.DEFAULT_STATISTICS_TRUNCATE_LENGTH);
+ public Statistics toParquetStatistics(String createdBy,
org.apache.parquet.column.statistics.Statistics stats) {
Review Comment:
I agree with @wgtmac.
Or, we can deprecate the static methods (marking them for removal in 2.0)
and create non-static ones to be used from now on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
