Fokko commented on code in PR #3269:
URL: https://github.com/apache/parquet-java/pull/3269#discussion_r2303981429
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -1804,14 +1804,27 @@ private static void copy(SeekableInputStream from,
PositionOutputStream to, long
* @throws IOException if there is an error while writing
*/
public void end(Map<String, String> extraMetaData) throws IOException {
+ final long footerStart = out.getPos();
+
+ // Build the footer metadata) in memory using the helper stream
+ InMemoryPositionOutputStream buffer = new
InMemoryPositionOutputStream(footerStart);
Review Comment:
I agree with @wgtmac that this doesn't solve the problem, and also
introduces other issues by introducing another buffer. Since writes to object
stores are pretty expensive, those libraries often pre-allocate a rather big
buffer. Adding another buffer as suggested in the PR will introduce more memory
pressure, which I think should be avoided. This problem will amplify if you
write to a lot of files in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
