scovich commented on code in PR #520: URL: https://github.com/apache/parquet-format/pull/520#discussion_r2300764348
########## VariantShredding.md: ########## @@ -110,18 +119,19 @@ Shredded values must use the following Parquet types: Primitive values can be shredded using the equivalent Parquet primitive type from the table above for `typed_value`. -Unless the value is shredded as an object (see [Objects](#objects)), `typed_value` or `value` (but not both) must be non-null. +Unless the value is shredded as an object (see [Objects](#objects)), exactly one of `typed_value` or `value` must be present in each row. +Missing values in an optional group are encoded as missing values of the entire group. #### Arrays Arrays can be shredded by using a 3-level Parquet list for `typed_value`. -If the value is not an array, `typed_value` must be null. -If the value is an array, `value` must be null. +If the value is not an array, `typed_value` must be missing. Review Comment: Ack. I was trying to follow the existing wording as closely as possible, and "missing" was used vastly more often than "NULL." But the real goal is clarity, not conformity to existing wording! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
