pan3793 commented on code in PR #3262:
URL: https://github.com/apache/parquet-java/pull/3262#discussion_r2292571566
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -943,6 +965,51 @@ public ParquetFileReader(InputFile file,
ParquetReadOptions options, SeekableInp
f.close();
throw e;
}
+
+ this.fileMetaData = footer.getFileMetaData();
Review Comment:
~`readFooter` is a public API, I don't think we should change the semantics
silently~
oh, I see, you add a new parameter `closeStreamOnFailure `
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -943,6 +965,51 @@ public ParquetFileReader(InputFile file,
ParquetReadOptions options, SeekableInp
f.close();
throw e;
}
+
+ this.fileMetaData = footer.getFileMetaData();
Review Comment:
~`readFooter` is a public API, I don't think we should change the semantics
silently~
oh, I see, you add a new parameter `closeStreamOnFailure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
