zeroshade commented on code in PR #512: URL: https://github.com/apache/parquet-format/pull/512#discussion_r2279916237
########## VariantShredding.md: ########## @@ -126,7 +126,8 @@ The list `element` must be a required group. The `element` group can contain `value` and `typed_value` fields. The element's `value` field stores the element as Variant-encoded `binary` when the `typed_value` is not present or cannot represent it. The `typed_value` field may be omitted when not shredding elements as a specific type. -When `typed_value` is omitted, `value` must be `required`. +The `value` field may be omitted when shredding elements as a specific type. Review Comment: That means the test cases which test with the fields being required should also get notes that they are invalid based on the spec? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
