JFinis commented on code in PR #514:
URL: https://github.com/apache/parquet-format/pull/514#discussion_r2272762817
##########
src/main/thrift/parquet.thrift:
##########
@@ -1211,6 +1316,16 @@ struct ColumnIndex {
* Same as repetition_level_histograms except for definitions levels.
**/
7: optional list<i64> definition_level_histograms;
+
+ /**
+ * A list containing the number of NaN values for each page. Only present
+ * for columns of physical type FLOAT or DOUBLE, or logical type FLOAT16.
+ * If this field is not present, readers MUST assume that there might or
+ * might not be NaN values in any page, as NaNs should not be included
+ * in min_values or max_values.
+ */
+ 8: optional list<i64> nan_counts
Review Comment:
That's the trade-off for nan_counts in general: You add fields to thrift
that are only relevant to floating point types. Let's see if there is any
objection on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
