mapleFU commented on code in PR #92: URL: https://github.com/apache/parquet-testing/pull/92#discussion_r2271856020
########## variant/regen.py: ########## @@ -78,6 +78,7 @@ -- https://github.com/apache/parquet-testing/issues/79 -- is not clear how to create the following types using Spark SQL -- TODO TimeNTZ (Type ID 17) Review Comment: Remove this line? ########## variant/regen.py: ########## @@ -78,6 +78,7 @@ -- https://github.com/apache/parquet-testing/issues/79 -- is not clear how to create the following types using Spark SQL -- TODO TimeNTZ (Type ID 17) +-- binary artifacts of TimeNTZ was generated by the iceberg test code, please ref to https://github.com/apache/parquet-testing/pull/92 for more detail -- TODO 'timestamp with timezone (NANOS)' (Type ID 18) -- TODO 'timestamp with time zone (NANOS)' (Type ID 19) -- TODO 'UUID' (Type ID 20) Review Comment: Would you mind generate other types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
