pan3793 commented on code in PR #3262:
URL: https://github.com/apache/parquet-java/pull/3262#discussion_r2259188854
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1054,13 +1121,17 @@ public List<BlockMetaData> getRowGroups() {
return blocks;
}
- public void setRequestedSchema(MessageType projection) {
+ public void setRequestedSchema(List<ColumnDescriptor> columns) {
Review Comment:
the diff here is not smart, this actually adds a new method
`public void setRequestedSchema(List<ColumnDescriptor> columns)`
there are many ctors of `ParquetFileReader` were marked as deprecated but
without providing the equivalent replacement, for example,
```
@Deprecated
public ParquetFileReader(
Configuration configuration,
FileMetaData fileMetaData,
Path filePath,
List<BlockMetaData> blocks,
List<ColumnDescriptor> columns)
```
this API is proposed to restore the ability to set read columns via
`List<ColumnDescriptor>`, instead of `MessageType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
