pyckle opened a new pull request, #3264: URL: https://github.com/apache/parquet-java/pull/3264
### Rationale for this change I wrote a driver for reading/writing flat parquet files column by column. ColumnReaderBase is used to read column values. In some use cases, multiple threads read the same ColumnChunk concurrently. In this scenario I want to avoid needless duplication of the immutable Dictionary object which in many cases copies the DictionaryPage into a primitive array store. In order to accomplish without upstream code changes, I abused Java reflection to set this field in a very roundabout way. See: https://github.com/Earnix/parquetforge/blob/74073acb4642a9dc9afd114e7151ae4f8288fdcf/parquetforge-base/src/main/java/com/earnix/parquet/columnar/reader/chunk/internal/HackyParquetExtendedColumnReader.java#L15 With a minor visibility change to the base class c-tor, and Dictionary as a c-tor parameter, this can be avoided ### What changes are included in this PR? ColumnReaderBase c-tor is changed to protected to support this integration. An additional c-tor is added that receives the Dictionary object. ### Are these changes tested? Yes. Existing tests cover these flows already. ### Are there any user-facing changes? No. Closes #3263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
