rdblue commented on code in PR #512: URL: https://github.com/apache/parquet-format/pull/512#discussion_r2252768334
########## VariantShredding.md: ########## @@ -125,8 +125,7 @@ If the value is an array, `value` must be null. The list `element` must be a required group. The `element` group can contain `value` and `typed_value` fields. The element's `value` field stores the element as Variant-encoded `binary` when the `typed_value` is not present or cannot represent it. -The `typed_value` field may be omitted when not shredding elements as a specific type. -When `typed_value` is omitted, `value` must be `required`. +The `typed_value` field may be omitted when not shredding elements as a specific type. The `value` field may be omitted when shredding elements as a specific type. However, at least one of the two fields must be present. Review Comment: Style: each sentence should be on a separate line in this file. I think it is fine to allow the `value` field to be omitted if it is entirely `null`. I'd support this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
