RussellSpitzer commented on code in PR #496: URL: https://github.com/apache/parquet-format/pull/496#discussion_r2237003206
########## LogicalTypes.md: ########## @@ -539,6 +544,30 @@ The sort order used for `INTERVAL` is undefined. When writing data, no min/max statistics should be saved for this type and if such non-compliant statistics are found during reading, they must be ignored. +#### YEAR_MONTH_INTERVAL + +`YEAR_MONTH_INTERVAL` is used to represent a year-month time interval, such as +`4 years and 6 months`. It must annotate an `int32` that stores the total number +of months as a signed integer, which represents the interval and can be negative. + +While ANSI SQL systems typically restrict supported intervals to a range of +±10,000 years and enforce this constraint internally, the Parquet format +does not impose any limitations on the interval values that may be stored. + +#### DURATION + +`DURATION` is used to represent a span of time, such as `5 days`. It must +annotate an `int64` value that stores the total number of time units for the +duration. The value is a signed integer and can be negative to indicate backward Review Comment: ```suggestion duration. The value is a signed integer and can be negative to indicate a backwards ``` Minor grammar fix^ But I am wondering if we have a better way to describe what a negative duration represents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
