wgtmac commented on code in PR #511: URL: https://github.com/apache/parquet-format/pull/511#discussion_r2233805059
########## VariantEncoding.md: ########## @@ -435,12 +435,12 @@ Similarly, user expressions operating on an *int8* value of 1 should behave the *Decimal table* -| Decimal Precision | Decimal value type | -|-----------------------|--------------------| -| 1 <= precision <= 9 | int32 | -| 10 <= precision <= 18 | int64 | -| 18 <= precision <= 38 | int128 | -| > 38 | Not supported | +| Decimal Precision | Decimal value type | Physical Type | Review Comment: ```suggestion | Decimal Precision | Decimal value type | Variant Physical Type | ``` Just to be consistent with the primitive type table above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
