pitrou commented on code in PR #496:
URL: https://github.com/apache/parquet-format/pull/496#discussion_r2160255294


##########
src/main/thrift/parquet.thrift:
##########
@@ -461,6 +461,29 @@ struct GeographyType {
   2: optional EdgeInterpolationAlgorithm algorithm;
 }
 
+/**
+ * Year-Month Interval logical type annotation
+ *
+ * The data is stored as an 4 byte signed integer which represents the number
+ * of months associated with the time interval. The value can be negative to
+ * indicate a backward duration.
+ *
+ * Allowed for physical type: INT32
+ */
+struct IntervalYearMonthType {
+}
+
+/**
+ * Month-Day Interval logical type annotation
+ *
+ * The data is stored as a 16-byte signed value, which represents the number

Review Comment:
   > Short answer is MonthDayNanos more closely mimics Postgres's notion of 
interval, where each field is separate (so a day is not guaranteed to be 24 
hours).
   
   MonthDayNanos is a data type, it does not mandate particular semantics. You 
can define interval addition however you want on top of it.
   
   (but, of course, making this new type a 16-byte nanosecond field encourages 
different semantics...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to