alamb commented on code in PR #84: URL: https://github.com/apache/parquet-testing/pull/84#discussion_r2103039341
########## variant/README.md: ########## @@ -45,8 +45,22 @@ Each example consists of 2 files: ## Regenerating these files -The files were generated by running the [`regen.py`](regen.py) script that uses Apache Spark to -generate the files. +The files in this directory were initially generated by running the [`regen.py`](regen.py) +script which used Apache Spark to generate the files. The files have been subsequently modified +when necessary to ensure that they conform to the Parquet spec. + +### Modification 1: Created metadata for `primitive_null` as a single byte (`0x01`) + +Per <https://github.com/apache/parquet-testing/issues/81>, Spark did not generate +any metadata for `null` and left `primitive_null.metadata` empty. +The metadata for `primitive_null` should be the same 3 bytes as other primitive types +* header = `0x01` +* dictionary_size = `0x00` +* `dictionary_size+1` `1` byte vales values: `0x00` Review Comment: Sorry, it is a typo. I'll try and clarify: ```suggestion * `dictionary_size + 1 = 1` byte values: `0x00` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
