pan3793 commented on code in PR #3208:
URL: https://github.com/apache/parquet-java/pull/3208#discussion_r2075157550
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -1743,8 +1743,12 @@ public OffsetIndex readOffsetIndex(ColumnChunkMetaData
column) throws IOExceptio
@Override
public void close() throws IOException {
+ close(true);
+ }
+
+ public void close(boolean closeFileInputStream) throws IOException {
Review Comment:
thanks for your suggestion, but are you comfortable removing the `final`
modifier for `f`?
```
protected final SeekableInputStream f;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
