szehon-ho commented on code in PR #494: URL: https://github.com/apache/parquet-format/pull/494#discussion_r2069469733
########## Geospatial.md: ########## @@ -94,6 +94,41 @@ Bounding box is defined as the thrift struct below in the representation of min/max value pair of coordinates from each axis. Note that X and Y Values are always present. Z and M are omitted for 2D geospatial instances. +Writers should follow the guidelines below when calculating bounding boxes in +the presence of edge cases. + +* `null` instance: Skip it and continue processing the remaining + geospatial instances. Do not produce a bounding box if all instances are null. +* Non-`null` instance with [special geospatial values](#special-geospatial-values): + * X and Y: Skip any special X or Y value and continue processing the Review Comment: OK sorry i equated levels 2 and 3 in my head (coordinate and value). But currently the language of 'special geospatial value' from the link mentions things like 'Nan (point)' , 'empty geometry', and 'invalid WKB' which seems to talk about invalid instances (level 1), which is my confusion. Then the section talks not about those, but about if actual x,v,z,m values (level 3) are invalid. Individual value is invalid only if NaN and outside the range (depending on context), right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
