zhangfengcdt commented on code in PR #3200:
URL: https://github.com/apache/parquet-java/pull/3200#discussion_r2063859011
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -520,6 +523,35 @@ public Optional<LogicalType>
visit(LogicalTypeAnnotation.IntervalLogicalTypeAnno
public Optional<LogicalType>
visit(LogicalTypeAnnotation.VariantLogicalTypeAnnotation variantLogicalType) {
return of(LogicalTypes.VARIANT(variantLogicalType.getSpecVersion()));
}
+
+ @Override
+ public Optional<LogicalType>
visit(LogicalTypeAnnotation.GeometryLogicalTypeAnnotation geometryLogicalType) {
Review Comment:
@wgtmac Thanks for the review comments and I have added some tests to
validate the handling of Geometry and Geography logical types in Parquet:
- testGeometryLogicalType - Verifies that Geometry types with CRS convert
correctly through schema serialization/deserialization
- testGeographyLogicalType - Ensures Geography types with CRS and
interpolation algorithm are preserved during schema conversion
- testGeometryLogicalTypeWithMissingCrs - Confirms that Geometry types
without specified CRS are handled properly (resulting in null CRS)
- testGeographyLogicalTypeWithMissingParameters - Checks that Geography
types with missing CRS and algorithm are correctly processed with null values
- testGeographyLogicalTypeWithAlgorithmButNoCrs - Validates that Geography
types with algorithm but no CRS are handled properly, preserving the algorithm
while CRS remains null
Please let me know if you have other cases that you would like you add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
