zhangfengcdt commented on PR #2971: URL: https://github.com/apache/parquet-java/pull/2971#issuecomment-2831037229
@wgtmac @jiayuasu I have made some clean ups of this PR and added some additional tests to cover the edge cases particularly for the invalid bbox scenarios. I added a new test cases in TestTypeBuilders which verifies the two new GEOMETRY/GEOGRAPHY types creation. Also, I added a comprehensive test `testMergingRowGroupBoundingBoxes` which simulates a real-world scenario provided in the spec clarification pr (https://github.com/apache/parquet-format/pull/494) where a file consists of multiple row groups with various geometric data, including valid points, points with NaN coordinates, and empty geometries. The TestBoundingBox incudes extensive tests on merging and updating bbox with/without invalid cases. I think it is now ready to review again, and please let me know if any changes need to be made. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
