pan3793 opened a new pull request, #3184: URL: https://github.com/apache/parquet-java/pull/3184
<!-- Thanks for opening a pull request! If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose and format pull request title as below: GH-${GITHUB_ISSUE_ID}: ${SUMMARY} or simply use the title below if it is a minor issue: MINOR: ${SUMMARY} --> ### Rationale for this change I found the partial output of `parquet footer xxx.parquet` is incorrect, for example, ``` "logicalTypeAnnotation" : { } ``` ### What changes are included in this PR? Supply a custom `JsonSerializer` for `LogicalTypeAnnotation` ### Are these changes tested? Currently, there is no output verification for parquet-cli modules, I manually checked the output of `org.apache.parquet.cli.commands.ShowFooterCommandTest` ```patch }, { "name" : "date_field", "repetition" : "REQUIRED", - "logicalTypeAnnotation" : { }, + "logicalTypeAnnotation" : "DATE", "id" : null, "primitive" : "INT32", "length" : 0, "decimalMeta" : null, "columnOrder" : { "columnOrderName" : "TYPE_DEFINED_ORDER" } } ], ``` ### Are there any user-facing changes? Only affects the output of parquet-cli. <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
