Kontinuation commented on code in PR #2971:
URL: https://github.com/apache/parquet-java/pull/2971#discussion_r1961669850
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java:
##########
@@ -271,6 +271,14 @@ public Optional<PrimitiveComparator> visit(
LogicalTypeAnnotation.BsonLogicalTypeAnnotation
bsonLogicalType) {
return
of(PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR);
}
+
+ @Override
+ public Optional<PrimitiveComparator> visit(
+ LogicalTypeAnnotation.GeometryLogicalTypeAnnotation
geometryLogicalType) {
+ // ColumnOrder is undefined for GEOMETRY logical type. Use the
default comparator for
+ // now.
+ return
of(PrimitiveComparator.UNSIGNED_LEXICOGRAPHICAL_BINARY_COMPARATOR);
+ }
Review Comment:
This raises another problem: currently this PR generates min and max
statistics for geometry and geography columns, but that is explicitly
prohibited by the latest Parquet geo spec:
> The sort order used for `GEOMETRY` is undefined. When writing data, no
min/max statistics should be saved for this type and if such non-compliant
statistics are found during reading, they must be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
