0x26res commented on code in PR #3113:
URL: https://github.com/apache/parquet-java/pull/3113#discussion_r1959901747
##########
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java:
##########
@@ -260,7 +260,7 @@ private <T> Builder<? extends Builder<?, GroupBuilder<T>>,
GroupBuilder<T>> addF
return builder.primitive(INT32, getRepetition(descriptor));
}
if (messageType.equals(UInt32Value.getDescriptor())) {
- return builder.primitive(INT64, getRepetition(descriptor));
+ return builder.primitive(INT32, getRepetition(descriptor));
Review Comment:
@Fokko I think the Uint32Value, which is a basically a nullable uint32,
should use the same physical type as a non nullable uint32 (give or take the
nullable flag). In this case we should use 32 bits integer to be consistent.
Also even if we were to use int64 for the underlying parquet storage, it
won't be exposed to the user as the API for Uint32Value is provided by the
protobuf library and uses `int` in java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
