qian0817 commented on code in PR #3147:
URL: https://github.com/apache/parquet-java/pull/3147#discussion_r1946032903
##########
parquet-pig/src/test/java/org/apache/parquet/pig/TestDecimalUtils.java:
##########
@@ -60,12 +60,12 @@ public void testBinaryToDecimal() throws Exception {
// Test LONG
testDecimalConversion(Long.MAX_VALUE, 19, 0, "9223372036854775807");
testDecimalConversion(Long.MIN_VALUE, 19, 0, "-9223372036854775808");
- testDecimalConversion(0L, 0, 0, "0.0");
+ testDecimalConversion(0L, 0, 0, "0");
Review Comment:
For this use case, 0 is the correct value. Using double to construct
BigDecimal previously may lead to potential errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
