ConeyLiu commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1945914388
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java:
##########
@@ -295,14 +295,19 @@ public void writePageV2(
int rlByteLength = toIntWithCheck(repetitionLevels.size());
int dlByteLength = toIntWithCheck(definitionLevels.size());
int uncompressedSize = toIntWithCheck(data.size() +
repetitionLevels.size() + definitionLevels.size());
- // TODO: decide if we compress
- BytesInput compressedData = compressor.compress(data);
- if (null != pageBlockEncryptor) {
- AesCipher.quickUpdatePageAAD(dataPageAAD, pageOrdinal);
- compressedData =
BytesInput.from(pageBlockEncryptor.encrypt(compressedData.toByteArray(),
dataPageAAD));
+ BytesInput compressedData = BytesInput.empty();
+ int compressedSize = 0;
+ if (data.size() > 0) {
+ // TODO: decide if we compress
+ compressedData = compressor.compress(data);
+ if (null != pageBlockEncryptor) {
+ AesCipher.quickUpdatePageAAD(dataPageAAD, pageOrdinal);
+ compressedData =
+
BytesInput.from(pageBlockEncryptor.encrypt(compressedData.toByteArray(),
dataPageAAD));
+ }
+ compressedSize =
+ toIntWithCheck(compressedData.size() + repetitionLevels.size() +
definitionLevels.size());
}
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
