gszadovszky commented on code in PR #3118:
URL: https://github.com/apache/parquet-java/pull/3118#discussion_r1931908460
##########
parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java:
##########
@@ -587,16 +587,12 @@ public void testParquetInt96AsFixed12AvroType() throws
Exception {
}
@Test
- public void testParquetInt96DefaultFail() throws Exception {
+ public void testParquetInt96DefaultPass() throws Exception {
Review Comment:
The expected behavior is to fail INT96 reading by default. We should not
change this test.
##########
parquet-avro/src/main/java/org/apache/parquet/avro/AvroSchemaConverter.java:
##########
@@ -103,7 +103,7 @@ public AvroSchemaConverter() {
this.assumeRepeatedIsListElement = assumeRepeatedIsListElement;
this.writeOldListStructure = WRITE_OLD_LIST_STRUCTURE_DEFAULT;
this.writeParquetUUID = WRITE_PARQUET_UUID_DEFAULT;
- this.readInt96AsFixed = READ_INT96_AS_FIXED_DEFAULT;
+ this.readInt96AsFixed = true;
Review Comment:
Oh, I've missed the fact that this constructor is invoked from the
parameterless one, which is public. We shall keep the original default behavior
of the int96 reading for all cases but the one where we initialize
`AvroRecordConverter.CONVERTER`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
