emkornfield commented on code in PR #481:
URL: https://github.com/apache/parquet-format/pull/481#discussion_r1919358475
##########
VariantEncoding.md:
##########
@@ -399,6 +399,7 @@ The Decimal type contains a scale, but no precision. The
implied precision of a
| Timestamp | timestamp with time zone | `22` |
TIMESTAMP(isAdjustedToUTC=true, NANOS) | 8-byte little-endian
|
| TimestampNTZ | timestamp without time zone | `23` |
TIMESTAMP(isAdjustedToUTC=false, NANOS) | 8-byte little-endian
|
| UUID | uuid | `24` | UUID
| 16-byte big-endian
|
+| Fixed(L) | Byte array of length L | `25` |
FIXED_LEN_BYTE_ARRAY[L] | 4 byte little-endian size L, followed by
length-L big-endian bytes |
Review Comment:
> @emkornfield number range - you mean the type range? We can have from 0 -
31 with a few left. I think it makes sense to to add Short-fixed(L). Let me
know if you agree.
>
> > we can't have a 'short-fixed L' like we have for string because I think
we are already use the entire number range there.
I was talking about the range for "basic type", I'm OK adding it as a
separate "primitive type" though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org
For additional commands, e-mail: issues-h...@parquet.apache.org
