gszadovszky commented on PR #3121: URL: https://github.com/apache/parquet-java/pull/3121#issuecomment-2589251385
The noted performance gain is promising indeed. However, it would be nice to see actual numbers for different scenarios (flat columns, general nested columns, deeply nested columns) of read/write. You might even implement your performance tests in the module `parquet-benchmarks`. Unfortunately, I'm not expert in `parquet-protobuf` either not even talking about `ByteBuddy`. For the final PR review it would be a great help to have someone who have some experience with `ByteBuddy` even if not being a Parquet committer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@parquet.apache.org For additional commands, e-mail: issues-h...@parquet.apache.org
